Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(releases): refactor the global perspective menu #8359

Draft
wants to merge 12 commits into
base: corel
Choose a base branch
from

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Jan 22, 2025

Description

  • Refactor the global menu to not make repeated calls to hooks
  • Move GlobalPerspectiveMenu and associated components out from releases to core/perspective
  • Add verifications based on content releases being on / off that show / hide components and releases list

What to review

Does this make sense?

Testing

Added some tests, existing tests should pass

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 2:30pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 2:30pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 2:30pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 2:30pm
test-next-studio ⬜️ Ignored (Inspect) Jan 23, 2025 2:30pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Component Testing Report Updated Jan 23, 2025 2:33 PM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 21s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 35s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 3s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 2m 24s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 22, 2025

⚡️ Editor Performance Report

Updated Thu, 23 Jan 2025 14:35:04 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 27.0 efps (37ms) 28.2 efps (36ms) -2ms (-4.1%)
article (body) 72.5 efps (14ms) 72.5 efps (14ms) +0ms (-/-%)
article (string inside object) 27.0 efps (37ms) 29.0 efps (35ms) -3ms (-6.8%)
article (string inside array) 22.7 efps (44ms) 25.0 efps (40ms) -4ms (-9.1%)
recipe (name) 45.5 efps (22ms) 58.8 efps (17ms) -5ms (-22.7%)
recipe (description) 55.6 efps (18ms) 62.5 efps (16ms) -2ms (-11.1%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (6ms) +1ms (-/-%)
synthetic (title) 18.9 efps (53ms) 20.6 efps (49ms) -5ms (-8.5%)
synthetic (string inside object) 19.2 efps (52ms) 20.4 efps (49ms) -3ms (-5.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 47ms 60ms 429ms 629ms 10.1s
article (body) 14ms 16ms 20ms 89ms 230ms 5.3s
article (string inside object) 37ms 39ms 51ms 207ms 303ms 7.1s
article (string inside array) 44ms 45ms 56ms 175ms 286ms 7.0s
recipe (name) 22ms 24ms 27ms 60ms 0ms 7.6s
recipe (description) 18ms 20ms 21ms 48ms 0ms 4.7s
recipe (instructions) 5ms 6ms 7ms 9ms 0ms 3.0s
synthetic (title) 53ms 56ms 61ms 294ms 798ms 12.9s
synthetic (string inside object) 52ms 54ms 62ms 334ms 841ms 8.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 36ms 59ms 75ms 478ms 797ms 10.7s
article (body) 14ms 16ms 20ms 125ms 205ms 5.2s
article (string inside object) 35ms 37ms 39ms 60ms 0ms 6.3s
article (string inside array) 40ms 44ms 50ms 77ms 158ms 7.0s
recipe (name) 17ms 18ms 21ms 40ms 0ms 6.6s
recipe (description) 16ms 18ms 23ms 37ms 0ms 4.7s
recipe (instructions) 6ms 7ms 8ms 10ms 0ms 3.1s
synthetic (title) 49ms 52ms 57ms 272ms 639ms 12.8s
synthetic (string inside object) 49ms 52ms 71ms 527ms 535ms 8.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@RitaDias RitaDias force-pushed the sapp-1973-global-menu branch from b9a6a98 to 9265c68 Compare January 23, 2025 09:30
@RitaDias RitaDias force-pushed the sapp-1973-global-menu branch from 70bc63e to cfed06f Compare January 23, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant