Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): support serverDocumentActions flag in plugins #8233

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

pedrobonamin
Copy link
Contributor

Description

Server actions don't yet support version documents.
This PR includes some changes necessary to make it possible to opt out from the server document actions through a plugin config.
It also disables that flag in the releases plugin, so users using releases will get this value and they will not use server actions.

What to review

Is there any missing change?

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from juice49 January 10, 2025 09:12
@pedrobonamin pedrobonamin requested a review from a team as a code owner January 10, 2025 09:12
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 2:47pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 2:47pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 2:47pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 2:47pm
test-next-studio ⬜️ Ignored (Inspect) Jan 10, 2025 2:47pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Component Testing Report Updated Jan 13, 2025 8:27 AM (UTC)

❌ Failed Tests (47) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ❌ Failed (Inspect) 39s 10 0 5
formBuilder/ArrayInput.spec.tsx ❌ Failed (Inspect) 7s 2 0 1
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 23s 4 0 2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ❌ Failed (Inspect) 50s 11 1 6
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ❌ Failed (Inspect) 15s 4 0 2
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ❌ Failed (Inspect) 8s 2 0 1
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ❌ Failed (Inspect) 16s 4 0 2
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ❌ Failed (Inspect) 40s 10 0 5
formBuilder/inputs/PortableText/Input.spec.tsx ❌ Failed (Inspect) 53s 14 0 7
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 1m 1s 12 0 6
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ❌ Failed (Inspect) 8s 2 9 1
formBuilder/inputs/PortableText/Styles.spec.tsx ❌ Failed (Inspect) 16s 4 0 2
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 1s 14 0 7
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 10, 2025

⚡️ Editor Performance Report

Updated Fri, 10 Jan 2025 14:49:02 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 21.1 efps (48ms) 17.1 efps (59ms) +11ms (+23.2%) 🔴
article (body) 56.5 efps (18ms) 41.9 efps (24ms) +6ms (+34.7%) 🔴
article (string inside object) 22.7 efps (44ms) 18.5 efps (54ms) +10ms (+22.7%) 🔴
article (string inside array) 20.2 efps (50ms) 16.4 efps (61ms) +12ms (+23.2%) 🔴
recipe (name) 50.0 efps (20ms) 30.3 efps (33ms) +13ms (+65.0%) 🔴
recipe (description) 54.1 efps (19ms) 33.3 efps (30ms) +12ms (+62.2%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (7ms) +1ms (-/-%)
synthetic (title) 18.9 efps (53ms) 7.5 efps (134ms) +81ms (+151.9%) 🔴
synthetic (string inside object) 18.9 efps (53ms) 7.7 efps (131ms) +78ms (+146.2%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 48ms 70ms 77ms 451ms 888ms 11.3s
article (body) 18ms 22ms 29ms 224ms 411ms 6.3s
article (string inside object) 44ms 48ms 53ms 241ms 291ms 7.2s
article (string inside array) 50ms 52ms 58ms 318ms 271ms 7.9s
recipe (name) 20ms 22ms 25ms 42ms 0ms 6.9s
recipe (description) 19ms 20ms 21ms 35ms 0ms 4.5s
recipe (instructions) 6ms 7ms 9ms 9ms 0ms 3.1s
synthetic (title) 53ms 55ms 57ms 86ms 500ms 12.6s
synthetic (string inside object) 53ms 56ms 67ms 600ms 658ms 8.7s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 59ms 75ms 102ms 588ms 1961ms 13.7s
article (body) 24ms 30ms 42ms 234ms 463ms 6.9s
article (string inside object) 54ms 56ms 62ms 207ms 749ms 8.1s
article (string inside array) 61ms 65ms 74ms 192ms 1297ms 9.1s
recipe (name) 33ms 36ms 45ms 75ms 9ms 8.5s
recipe (description) 30ms 32ms 36ms 63ms 29ms 5.6s
recipe (instructions) 7ms 9ms 11ms 18ms 0ms 3.2s
synthetic (title) 134ms 141ms 165ms 662ms 6726ms 21.7s
synthetic (string inside object) 131ms 136ms 147ms 699ms 5997ms 15.8s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin merged commit 4d4aba8 into corel Jan 13, 2025
52 of 54 checks passed
@pedrobonamin pedrobonamin deleted the corel-disable-server-actions branch January 13, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants