-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix missing await on assertions for resolveInitialValue()
#8080
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
44f7827
to
6c1a06c
Compare
6c1a06c
to
1a2f4ed
Compare
No changes to documentation |
⚡️ Editor Performance ReportUpdated Mon, 16 Dec 2024 22:08:36 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
Component Testing Report Updated Dec 16, 2024 10:11 PM (UTC) ❌ Failed Tests (2) -- expand for details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
Description
Promise-based tests should be awaited - vitest complained about some tests not doing this. This PR fixes that
What to review
Tests pass
Testing
Tests are already in place, just needed to be async/awaited
Notes for release
None