chore(ci) fix prettier & eslint workflows #5740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Feb 14, 2024 7:29 PM (UTC)
|
binoy14
reviewed
Feb 14, 2024
package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| "check:test": "run-s test -- --silent", | |||
| "check:types": "tsc --build", | |||
| "chore:format:fix": "prettier --cache --write .", | |||
| "chore:lint:fix": "pnpm check:lint -- --quiet --fix", | |||
| "chore:lint:fix": "run-s check:lint -- --quiet --fix", | |||
There was a problem hiding this comment.
might be better to just use turbo directly here I think the args passing multiple times gets messed up
Suggested change
| "chore:lint:fix": "run-s check:lint -- --quiet --fix", | |
| "chore:lint:fix": "turbo run lint -- --quiet --fix", |
3b088d1 to
a539273
Compare
bjoerge
added a commit
that referenced
this pull request
Feb 15, 2024
bjoerge
added a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging to next revealed a couple of issues with lint/prettier scripts. This should hopefully fix it.
Testing
Not sure if it's possible to properly test these before merging, unfortunately
Notes for release
N/A