Migrate to importlib.metadata. #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As initially identified in [Debian bug #1083383], Fastaq depends on the Python module pkg_resources, [deprecated] since python3.11 and obsoleted in python3.13, in favor of [importlib.metadata], available since python3.8. In case Fastaq still needs to cover ancient Python interpreter versions preceeding 3.8, the change also includes a fallback to pkg_resources if the importlib is not located properly. [Debian bug #1083383]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083383 [deprecated]: https://setuptools.pypa.io/en/latest/pkg_resources.html [importlib.metadata]: https://docs.python.org/3.11/library/importlib.metadata.html#module-importlib.metadata Signed-off-by: Étienne Mollier <emollier@debian.org>
When packaging information is missing, the initial proposal missed falling back to the 'local' version properly. This change adjusts the try/except logic to accomodate to that situation properly. Signed-off-by: Étienne Mollier <emollier@debian.org>
|
Thanks for this, sorry I didn't merge sooner. But - I think is now all sorted by (and might conflict with, haven't checked properly) by PR #86, which am about to merge ...? |
|
Hi martinghunt, Thanks for your comment, no worries on the delay, I know way worse. ;) I had a look at #86 and I agree that my merge request is now irrelevant, hereby closing it. Have a nice day, :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As initially identified in Debian bug #1083383, Fastaq depends on the Python module pkg_resources, deprecated since python3.11 and obsoleted in python3.13, in favor of importlib.metadata, available since python3.8.
In case Fastaq still needs to cover ancient Python interpreter versions preceeding 3.8, the change also includes a fallback to pkg_resources if the importlib is not located properly.