Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action Required: Do Not Merge WIP for GitHub Requires Changes to Comply with Chrome Web Store Policy #333

Closed
sanemat opened this issue Mar 31, 2023 · 6 comments
Closed

Action Required: Do Not Merge WIP for GitHub Requires Changes to Comply with Chrome Web Store Policy #333

sanemat opened this issue Mar 31, 2023 · 6 comments

Comments

@sanemat
Copy link
Owner

sanemat commented Mar 31, 2023

We wanted to let you know that your item is at risk of being removed from the Chrome Web Store. Please find the details below.

Item name: Do Not Merge WIP for GitHub

Item ID: nimelepbpejjlbmoobocpfnjhihnpked

Violation(s):

Use of Permissions:

Violation reference ID: Purple Potassium
Violation: Requesting but not using the following permission(s):
storage
How to rectify: Remove the above permission(s)
Relevant section of the program policy:
Request access to the narrowest permissions necessary to implement your Product's features or services. Don't attempt to "future proof" your Product by requesting a permission that might benefit services or features that have not yet been implemented. (learn more)

Important information about resubmission:

Please make the necessary changes within 14 days in order to avoid removal.
@sanemat
Copy link
Owner Author

sanemat commented Apr 2, 2023

do-not-merge-wip-for-github/app/manifest.json

Lines 10 to 12 in d01de90

"permissions": [
"storage"
],

@sanemat
Copy link
Owner Author

sanemat commented Apr 2, 2023

we use it 🤔
83e26ca

@sanemat
Copy link
Owner Author

sanemat commented Apr 2, 2023

https://developer.chrome.com/docs/webstore/troubleshooting/#misunderstood-perms-storage

storage

The storage permission exposes the chrome.storage API to the extension.

When is it required?
When using the chrome.storage API.
When is it NOT required?
When using the Web Storage API (document.localStorage, document.sessionStorage) or IndexedDB.

@sanemat
Copy link
Owner Author

sanemat commented Apr 2, 2023

https://developer.chrome.com/docs/extensions/migrating/mv2-sunset/

sanemat added a commit that referenced this issue Apr 2, 2023
@sanemat
fix(permissions): drop storage
8bee3a1 
for using `document.localStorage`, we don't need
storage permissions.

https://developer.chrome.com/docs/webstore/troubleshooting/#misunderstood-perms-storage

refs #333
@sanemat sanemat mentioned this issue Apr 2, 2023
Merged
@sanemat
Copy link
Owner Author

sanemat commented Apr 2, 2023 •
edited
Loading

I submitted for review v2.0.3 🙏

@sanemat
Copy link
Owner Author

sanemat commented Apr 2, 2023

v2.0.3 🎉
https://chrome.google.com/webstore/detail/do-not-merge-wip-for-gith/nimelepbpejjlbmoobocpfnjhihnpked

@sanemat sanemat closed this as completed Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sanemat