Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover becomes dismissible after another popover on the page is opened #248

Open
sbrodkey opened this issue Sep 1, 2017 · 6 comments
Open

Comments

@sbrodkey
Copy link

sbrodkey commented Sep 1, 2017

If I enter the page, open my desired popover, and click outside the popover it stays open.

If I then open another popover, close it, open my desired popover and click outside, the popover closes! It also closes when I choose an option from a select box in my popover.

I've tried every possible setting to no avail, including key ones such as dismissible: false and trigger:manual. Even with both of those set, it still closes upon outside click.

Is there any possible way to prevent my desired popover from closing (due to an outside click or select option click) simply due to the fact that I opened another popover?

@sbrodkey
Copy link
Author

sbrodkey commented Sep 5, 2017

After much more experimentation of settings, I found that setting dismissible:false on the other popover made the desired popover not close.

It seems highly error prone in that to make one popover dismissible, we need to set every other popover on the page to be dismissible as well. This is likely something that needs to be investigated deeper into the webuiPopover core code.

@sbrodkey
Copy link
Author

sbrodkey commented Sep 5, 2017

So, my proposed change here is the "dismissible" be on a per-popover basis, rather needing set all popovers to be non-dismissible for each popover to be non-dismissible.

@sbrodkey
Copy link
Author

sbrodkey commented Sep 5, 2017

I've solved the issue. Will submit a PR later today.

sbrodkey pushed a commit to sbrodkey/webui-popover that referenced this issue Sep 6, 2017
@gvcayetano
Copy link

@sbrodkey how did you solve the issue? I encountered the same problem where I have a non-dismissible popover but when I open a dismissible one my non-dismissible popover turns into a dismissible. :(

@ketokun
Copy link

ketokun commented Nov 27, 2018

@sbrodkey or @gvcayetano did you find a workaround eventually?

@gvcayetano
Copy link

gvcayetano commented Nov 27, 2018

@ketokun here's the link to @sbrodkey 's PR #250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants