add plugin @routes-gen/solid-start #29
Conversation
But notice we need to merge the patch to solid-start or do some patching
|
@nirtamir2 answered in #28. |
| resolve([]); | ||
| } else { | ||
| const routes = JSON.parse(stdout) as Array<SolidStartRouteData>; | ||
| const filteredRoutes = routes.filter((route) => { |
There was a problem hiding this comment.
As I see in the remix plugin - I filter the * paths.
| export const routes: Driver["routes"] = async () => { | ||
| const parsedRoutes = await new Promise<Array<SolidStartRouteData>>( | ||
| async (resolve) => { | ||
| exec(`npx solid-start routes`, (error, stdout) => { |
There was a problem hiding this comment.
since v0.2.10 this is valid command
|
@sandulat It's ready for review! 🎉 |
|
@nirtamir2 Sorry for the delay, I need to find some time to test it, since I've never used Solid/Solid Start before. |
|
@sandulat you can use https://github.com/nirtamir2/solid-start-starter/tree/routes-gen-published and replace my published package with the code you want, or just inline it like I've done in https://github.com/nirtamir2/solid-start-starter/tree/routes-gen |
|
@sandulat Any update? Can I help somehow? |
|
@nirtamir2 At first glance, everything seems to be working. After doing the tiny fixes I've requested above, we can publish the package right away. |
|
@sandulat Thanks! I fixed the issues |
|
Thank you so much @nirtamir2! <3 |
This PR adds a new plugin
@routes-gen/solid-start.You can see it running and published under
@nirtamir2/routes-gen-solid-startand play with it in https://github.com/nirtamir2/solid-start-starter/tree/routes-gen-publishedCloses #28