Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change StringSlice -> String for Viper consistency #8

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

luker983
Copy link
Collaborator

@luker983 luker983 commented Mar 23, 2023

@DennyDai I believe this should address the consistency concerns brought up in #7. Environment variables, config files, and command line flags all support comma-separated CIDRs this way.

@DennyDai
Copy link
Contributor

LGTM, tested and works on my end. Thank you :)

@luker983 luker983 merged commit 3ba1027 into main Mar 23, 2023
@luker983 luker983 deleted the allowedips-consistency branch March 23, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants