Refactor spack-manager to be a plugin #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psakievich
added a commit
that referenced
this pull request
Dec 7, 2023
* Begin Refactor spack-manager to be a plugin
psakievich
added a commit
that referenced
this pull request
Dec 7, 2023
* Refactor spack-manager to be a plugin
psakievich
added a commit
that referenced
this pull request
Feb 6, 2024
* Refactor spack-manager to be a plugin
psakievich
added a commit
that referenced
this pull request
Feb 12, 2024
* Refactor spack-manager to be a plugin (#577)
psakievich
added a commit
that referenced
this pull request
May 1, 2024
* Refactor spack-manager to be a plugin (#577) * Refactor spack-manager to be a plugin * Update create-dev-env (#580) * Add pytest compatible patch replacement * Rework unit tests for create_dev_env * Revamp develop tests (#581) * Revamp develop tests * Give env a more specific name * Add fixture to register extension in mutable config * Update tests and calling args * Restore the external command (#582) * Restore the external command * Restore deleted line * Remove some SPACK_MANAGER env variable deps * Missed delete * Add documentation for how to setup a new project (#583) * Add introduction to projects concept * Update the project creation docs - Covers creating and populating configs * Machine detection process explained. * More updates, moving into repos * clean any projects that are loaded for unit tests * Fix doc reference and unit-test * Really fix unit-tests this time * Remove breakpoints * Make code certain a project exists * Remove unused problematic code * Add installation procedure (#586) * Add installation procedure * Fix path * Add include command (#587) * Add support for quick-commands (#588) * Add support for quick-commands * Remove lingering env var * Default view to false * Fix unit-tests * Style * Retool projects core (#589) * Retool projects core Split projects object and concept out of the manager module so they are created/updated each use * Clean up * Add interface for adding and removing projects * Style * Make include relative again * Add a `--project` filter for finding machines and creating environments (#590) * Add --project filter * Add to env creation * Style * Add a tool for configuring a new platform * Update platform_configure_tool.py * Fix scope * Add config location to find-machine * Style and test * Fix missing import * Fix unit test * F/make (#601) * Add 'make' command * Updates for spack-manager parsing * Add a -j arg for most common use case * Style and docs * Add first unit-test * Style
psakievich
added a commit
that referenced
this pull request
May 1, 2024
* Refactor spack-manager to be a plugin (#577) * Refactor spack-manager to be a plugin * Update create-dev-env (#580) * Add pytest compatible patch replacement * Rework unit tests for create_dev_env * Revamp develop tests (#581) * Revamp develop tests * Give env a more specific name * Add fixture to register extension in mutable config * Update tests and calling args * Restore the external command (#582) * Restore the external command * Restore deleted line * Remove some SPACK_MANAGER env variable deps * Missed delete * Add documentation for how to setup a new project (#583) * Add introduction to projects concept * Update the project creation docs - Covers creating and populating configs * Machine detection process explained. * More updates, moving into repos * clean any projects that are loaded for unit tests * Fix doc reference and unit-test * Really fix unit-tests this time * Remove breakpoints * Make code certain a project exists * Remove unused problematic code * Add installation procedure (#586) * Add installation procedure * Fix path * Add include command (#587) * Add support for quick-commands (#588) * Add support for quick-commands * Remove lingering env var * Default view to false * Fix unit-tests * Style * Retool projects core (#589) * Retool projects core Split projects object and concept out of the manager module so they are created/updated each use * Clean up * Add interface for adding and removing projects * Style * Make include relative again * Add a `--project` filter for finding machines and creating environments (#590) * Add --project filter * Add to env creation * Style * Add a tool for configuring a new platform * Update platform_configure_tool.py * Fix scope * Add config location to find-machine * Style and test * Fix missing import * Fix unit test * F/make (#601) * Add 'make' command * Updates for spack-manager parsing * Add a -j arg for most common use case * Style and docs * Add first unit-test * Style * Update docs * Update action versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be a big PR to rework the guts of spack-manager so that it is a plugin that is independent of the exawind project and spack instance. Key steps include:
PYTHONPATHPATHenv variablesfind-machineand associated config matching extendable via the yaml config in the step above.The end goal of this PR is that the
find-machineandcreate-envcommands will work again via testing and can be extended to other projects.Pinging @alalazo for your radar