Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ecto format function infinite recursion loop #18

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Fix Ecto format function infinite recursion loop #18

merged 1 commit into from
Apr 8, 2019

Conversation

hidnasio
Copy link
Contributor

@hidnasio hidnasio commented Apr 5, 2019 •
edited
Loading

Fix an infinite recursion when the query "SELECT a, b, c, d, e, f FROM users AS u0 where u0.id = 5" is formatted.

Also update format/3 private function from PrettyPrintFormatter.Ecto to be tailless recursive.

@hidnasio hidnasio mentioned this pull request Apr 5, 2019
Closed
@hidnasio hidnasio changed the title Fix Ecto format function infinity recursion loop Fix Ecto format function infinite recursion loop Apr 5, 2019
@hidnasio hidnasio force-pushed the ecto_format_infinity_recursion branch from fe51f7c to f6e1299 Compare April 7, 2019 00:00
@san650 san650 merged commit 0574115 into san650:master Apr 8, 2019
@hidnasio hidnasio deleted the ecto_format_infinity_recursion branch April 8, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hidnasio @san650