some deprecations

[tacman]

I saw these. I think it's okay to simply follow the suggestions, but can't remember exactly if they'd work for PHP 7.2.

[samwilson]

With the addition of UriInterface as a return type hint, Phan is now complaining:

src/Oauth/PhpFlickrService.php:39 PhanUndeclaredTypeReturnType Return type of getRequestTokenEndpoint() is undeclared type \OAuth\Common\Http\Uri\UriInterface

src/Oauth/PhpFlickrService.php:41 PhanTypeMismatchReturn Returning new Uri((static::$baseUrl . '/oauth/request_token')) of type \OAuth\Common\Http\Uri\Uri but getRequestTokenEndpoint() is declared to return \OAuth\Common\Http\Uri\UriInterface

[tacman]

Yeah, I just ran into phpstan complaining in another project. I'm never quite sure when to return self, static or the class/interface name itself.

[samwilson]

It's a bit strange. It's like Phan is not loading vendor classes, but it must be because surely otherwise it'd be complaining about a bunch of other stuff.

[samwilson]

Oh, Phan was not loading the vendor directory! Fixing now.