Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Increase size of action menu items #6953

Merged
merged 1 commit into from
Nov 1, 2024
Merged

a11y: Increase size of action menu items #6953

merged 1 commit into from
Nov 1, 2024

Conversation

dlpierce
Copy link
Contributor

@dlpierce dlpierce commented Nov 1, 2024

Fixes

Fixes #6932

@dlpierce dlpierce added the notes-accessibility Release Notes: Accessibility label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 19m 49s ⏱️ + 4m 8s
 6 717 tests ±0   6 420 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 204 runs  ±0  12 808 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit 5d89b76. ± Comparison against base commit 5e7f26d.

This pull request removes 265 and adds 265 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f96eabc9110>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa9b3fb0018>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f96f0660150>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa9b4144398>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: bb9ee608-3e7d-4f05-a47a-cb098b762eb6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 2d064183-5c8b-4bb0-8d25-b2cff57cfdfc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a4c57463-f096-4574-a69b-8cc8ecc77b7c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: ac9896b9-f8d4-4171-811d-1a07a5396600
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 51f688be-963c-45ca-b29c-91632b30077d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: fa27940d-6559-464d-891e-5dfabb7eb229
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fbb1012e8a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fdcf9f32f90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fbb100949d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fdcfc62eb08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 07628694-60e6-4940-903a-f2aa7ff02795
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: cb699744-ed93-4a54-8f57-74f20283a9fb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: e0c7633a-aafc-4474-a100-2d2238de19e4
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: d8062944-982e-45f0-acd9-a9f13ff99fd6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: a2e4a2e8-c912-4391-b5de-4c9390d0bcd3
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 19d01b98-06d8-4dbb-afa0-b841b0109224
…

@randalldfloyd randalldfloyd merged commit 24e6979 into main Nov 1, 2024
22 checks passed
@randalldfloyd randalldfloyd deleted the action-size branch November 1, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-accessibility Release Notes: Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select an Action in Items list on Work view page does not minimum size requirements for interactive elements
2 participants