-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize callbacks by using solr instead of find_collections_by_type #6925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 17 files + 1 17 suites +1 2h 17m 26s ⏱️ + 16m 36s Results for commit 8a4172d. ± Comparison against base commit 0ffde70. This pull request removes 178 and adds 533 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
dlpierce
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ensure_no_collections
andensure_no_settings_changes_if_collections_exist
have guards which return early if any collections exist for the given collection type. It appears that the existing approach fetches all of the collection objects before testing with.any?
. For the fedora adapter (and possibly other adapters) this will lead to reading all of the objects in the repository before filtering for collection model objects (see https://github.com/samvera/hyrax/blob/main/app/services/hyrax/custom_queries/find_collections_by_type.rb#L31 and https://github.com/samvera/valkyrie/blob/main/lib/valkyrie/persistence/fedora/query_service.rb#L82). To avoid that we can search solr for a count of collections and test it is greater than 0.Resolves #6888
@samvera/hyrax-code-reviewers