Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Matotomo error handling #6921

Merged

Conversation

iccole
Copy link
Contributor

@iccole iccole commented Oct 10, 2024

Fixes

Fixes 6920

Summary

In the same spirit of the existing behavior, this detects errors reported from matomo and fails gracefully

@iccole iccole force-pushed the bugfix/matomo-error-handling branch from 2186d80 to a7cefc3 Compare October 10, 2024 19:03
@orangewolf
Copy link
Member

looking good to me =-)

Copy link

github-actions bot commented Oct 11, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 18m 37s ⏱️ - 2m 26s
 6 706 tests ±0   6 409 ✅ +1  297 💤 ±0  0 ❌  - 1 
13 180 runs  ±0  12 785 ✅ +1  395 💤 ±0  0 ❌  - 1 

Results for commit 8d43271. ± Comparison against base commit f77472d.

This pull request removes 272 and adds 272 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f80f4cedc00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f8fb92ccba8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f80f4c4be00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f8fb84e7ee8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 5df7d499-6552-4102-a913-86d67630c8ea
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 8eadeeb8-f856-4737-8542-0bdf7aabe98d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: f6496b1c-b929-4fa3-ab68-b84844f3e73b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 634b6383-85a4-4961-b70a-2d896515ab43
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 3a4668fc-88bf-437c-b4da-278ff5853330
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: e08b6f6a-c456-4f0c-8df3-78bae20aeccf
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f79cb1358c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fda5fd02320>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f79c53e0f08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fda5fd0dfe0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: e685d442-40de-485f-8f3f-0daea6b35ff8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 79a3763c-480c-4001-b72f-05fd27715976
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 8cb2ad2f-4eb1-44eb-b81d-722d063cffe4
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 62e6ca8b-eef8-4261-9759-2914f4a75b1e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 33fd8237-2367-4746-9210-fb54b5b9e0b2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 20a6dfd8-bcdb-4608-aa2e-a40b027768f4
…

♻️ This comment has been updated with latest results.

@iccole iccole force-pushed the bugfix/matomo-error-handling branch from a7cefc3 to 8d43271 Compare October 11, 2024 19:07
@iccole
Copy link
Contributor Author

iccole commented Oct 11, 2024

@orangewolf Thanks :)

@iccole
Copy link
Contributor Author

iccole commented Oct 14, 2024

@orangewolf I rebased with the newest changes from main. Because of that I'm guessing the test run is no longer associated with the right commit. Is there anything I can do about that?

@orangewolf
Copy link
Member

@iccole i was able to retrigger the specs. Looks great

@orangewolf orangewolf merged commit 0ffde70 into samvera:main Oct 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved Matomo error response handling
2 participants