-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Matotomo error handling #6921
Improved Matotomo error handling #6921
Conversation
2186d80
to
a7cefc3
Compare
looking good to me =-) |
Test Results 17 files ±0 17 suites ±0 2h 18m 37s ⏱️ - 2m 26s Results for commit 8d43271. ± Comparison against base commit f77472d. This pull request removes 272 and adds 272 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
a7cefc3
to
8d43271
Compare
@orangewolf Thanks :) |
@orangewolf I rebased with the newest changes from main. Because of that I'm guessing the test run is no longer associated with the right commit. Is there anything I can do about that? |
@iccole i was able to retrigger the specs. Looks great |
Fixes
Fixes 6920
Summary
In the same spirit of the existing behavior, this detects errors reported from matomo and fails gracefully