-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding alt attribute on thumbnail in search results list view #6911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also addresses #6891 (same report using WAVE instead of SiteImprove) |
Test Results 17 files ±0 17 suites ±0 2h 16m 53s ⏱️ +18s Results for commit 36b4120. ± Comparison against base commit e4886f1. This pull request removes 273 and adds 273 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
dlpierce
approved these changes
Sep 26, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6749 - This adds alternative text on thumbnails in the search results list view but not on the gallery or masonry views. Those views currently have empty alt attributes and are passing accessibility test via SiteImprove but are not actually providing any alternative text.
Summary
Calling up work title and using that for alternative text attribute value
Type of change (for release notes)
notes-minor
Addresses accessibility-concern of missing alternative text@samvera/hyrax-code-reviewers