Review and Approval panel style fixes #6364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Between hyrax 3 and 4 the layout and styling of the Review and Approval changed significantly, which seems unintentional after reviewing the commit history for that file.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
In the hyrax dassie environment, create an admin set with the "One stop mediated deposit" workflow. Deposit a work into this admin set. On the resulting work page, expand the "Review and Approval" panel at the top of the page. Compare this between a hyrax 3 and 4/5 instance.
Type of change (for release notes)
notes-bugfix
Detailed Description
There were a number of style and layout changes, likely the result of the bootstrap upgrade. The issues include:
See the following screenshot for the hyrax-3 display:
And the hyrax-5 display:
Changes proposed in this pull request:
This PR should fix the listed issues, although it still looks a little different due to new defaults in bootstrap 5.
@samvera/hyrax-code-reviewers