Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and Approval panel style fixes #6364

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Review and Approval panel style fixes #6364

merged 3 commits into from
Oct 17, 2023

Conversation

bbpennel
Copy link
Contributor

Summary

Between hyrax 3 and 4 the layout and styling of the Review and Approval changed significantly, which seems unintentional after reviewing the commit history for that file.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

In the hyrax dassie environment, create an admin set with the "One stop mediated deposit" workflow. Deposit a work into this admin set. On the resulting work page, expand the "Review and Approval" panel at the top of the page. Compare this between a hyrax 3 and 4/5 instance.

Type of change (for release notes)

notes-bugfix

Detailed Description

There were a number of style and layout changes, likely the result of the bootstrap upgrade. The issues include:

  • The main button/header to expand the panel now has a large white padding around it
  • Inside the panel, all the components are now arranged into a single column at any window width, whereas before the "Actions" section was on the left and the other parts were to the right (the bootstrap columns are still arranged this way)
  • The "Actions" section no longer has padding at the top and bottom, so it looks cut off
  • The label for the comments input is no longer bold
  • There is very little spacing between the submit button and the "Previous comments" section

See the following screenshot for the hyrax-3 display:
hyrax3_review_approval
And the hyrax-5 display:
hyrax5_review_approval

Changes proposed in this pull request:

  • Updates to css and added a row div

This PR should fix the listed issues, although it still looks a little different due to new defaults in bootstrap 5.
hyrax5_review_approval_fixed

@samvera/hyrax-code-reviewers

Copy link
Contributor

@dlpierce dlpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better. Thank you!

@dlpierce dlpierce merged commit 0d09dae into main Oct 17, 2023
@dlpierce dlpierce deleted the workflow_style_fixes branch October 17, 2023 14:12
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants