remove tests for test only code (Factories) #6265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these factories are ActiveFedora only and won't pass the specs cross environment. we could cordon them of as `:active_fedora` but i can't see the value in having tests for test infrastructure that isn't generally changing. very likely, if the factories changed in a way that was bad, many existing tests would fail. i propose removing the specs as more trouble than they're worth.
tpendragon
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these factories are ActiveFedora only and won't pass the specs cross environment. we could cordon them of as
:active_fedorabut i can't see the value in having tests for test infrastructure that isn't generally changing.very likely, if the factories changed in a way that was bad, many existing tests would fail. i propose removing the specs as more trouble than they're worth.
@samvera/hyrax-code-reviewers