never set metadata/storage_adapter to wings or AF if disable_wings
#6256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some test on `.koppie` seem to fail on test order(?) issues, when they decide to use the Wings adapter for metadata persistence. it seems like something during the test suite run is setting the adapter to `:wings_adapter` and then not unsetting it. my best guess is that something is requiring `wings` or `wings/setup` (maybe via `wings/helper`) during the test run.
5165d9e to
9cb8e76
Compare
dunn
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some test on
.koppieseem to fail on test order(?) issues, when they decide to use the Wings adapter for metadata persistence. it seems like something during the test suite run is setting the adapter to:wings_adapterand then not unsetting it. my best guess is that something is requiringwingsorwings/setup(maybe viawings/helper) during the test run.@samvera/hyrax-code-reviewers