Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsupported ARIA attributes in expanded Your Activity and Settings menus #6840

Closed
rjkati opened this issue Jun 21, 2024 · 2 comments · Fixed by #6980
Closed

unsupported ARIA attributes in expanded Your Activity and Settings menus #6840

rjkati opened this issue Jun 21, 2024 · 2 comments · Fixed by #6980
Labels
accessibility-concern aria-concern

Comments

@rjkati
Copy link

rjkati commented Jun 21, 2024

Descriptive summary

On dev.nurax.samvera.org (Hyrax 5.0.1), the Your Activity and Settings menus contain unsupported ARIA attributes when expanded.

Steps to reproduce the behavior in User Interface (UI)

  1. In Chrome, download the Site Improve browser extension
  2. Go to https://dev.nurax.samvera.org/dashboard?locale=en, expand the Your Activity menu and run the Site Improve browser extension
    aria-menu
@aahurford
Copy link

tested and confirmed

rodyoukai added a commit to rodyoukai/hyrax that referenced this issue Dec 7, 2024
@rodyoukai
fix samvera#6840
f441894
@rodyoukai rodyoukai mentioned this issue Dec 7, 2024
Merged
@jlhardes jlhardes moved this from Ready for Dev/Doc (priority ordered) to QA in Hyrax Accessibility Community Sprint 2024 Dec 11, 2024
@christhepianist
Copy link

Confirmed that this is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility-concern aria-concern
Projects
Hyrax Accessibility Community Sprint 2024
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unsupported aria attributes in dashboard rodyoukai/hyrax
3 participants
@christhepianist @rjkati @aahurford