Merge pull request #6376 from samvera/rm-dep-reset-acl

Remove deprecated `reset_access_controls!`

app/forms/hyrax/forms/permission_template_form.rb

@@ -9,13 +9,6 @@ class PermissionTemplateForm
       delegate :access_grants, :access_grants_attributes=, :release_date, :release_period, :visibility, to: :model
       delegate :available_workflows, :active_workflow, :source, :source_id, to: :model
 
-      ##
-      # @deprecated  use PermissionTemplate#reset_access_controls_for instead.
-      def reset_access_controls!
-        Deprecation.warn("reset_access_controls! is deprecated; use PermissionTemplate#reset_access_controls_for instead.")
-        source_model.reset_access_controls!
-      end
-
       # Stores which radio button under release "Varies" option is selected
       attr_accessor :release_varies
       # Selected release embargo timeframe (if any) under release "Varies" option

spec/forms/hyrax/forms/permission_template_form_spec.rb

@@ -14,7 +14,6 @@
   it { is_expected.to delegate_method(:source_model).to(:model) }
   it { is_expected.to delegate_method(:source_id).to(:model) }
   it { is_expected.to delegate_method(:visibility).to(:model) }
-  it { is_expected.to delegate_method(:reset_access_controls!).to(:source_model) }
 
   it 'is expected to delegate method #active_workflow_id to #active_workflow#id' do
     workflow = double(:workflow, id: 1234, active: true)

spec/models/collection_spec.rb

@@ -201,7 +201,7 @@ class Member < ActiveFedora::Base
     end
   end
 
-  describe '#reset_access_controls!' do
+  describe 'permission_template reset_access_controls_for' do
     let!(:user) { build(:user) }
     let(:collection_type) { create(:collection_type) }
     let!(:collection) { FactoryBot.build(:collection_lw, user: user, collection_type: collection_type) }