Skip to content

Commit

Permalink
Lock simple_form less strictly
Browse files Browse the repository at this point in the history
We previously supported `~> 3.2`. The regression introduced in v3.5.1 is
described at heartcombo/simple_form#1549. We'll
need to fix our presenters to be `ActiveModel` compliant to make `simple_form`
work correctly past that version.

In the meanwhile, we shouldn't require any simple_form upgrade as part of an
upcoming Hyrax release.
  • Loading branch information
Tom Johnson committed Mar 2, 2018
1 parent 8db029f commit c634b37
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions hyrax.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,9 @@ SUMMARY
########################################################
# Temporarily pinned dependencies. INCLUDE EXPLANATIONS.
#
# simple_form 3.5.1 broke local and Travis builds in bad ways for unknown reasons
spec.add_dependency 'simple_form', '=3.5.0'
# simple_form 3.5.1 broke hydra-editor for certain model types;
# see: https://github.com/plataformatec/simple_form/issues/1549
spec.add_dependency 'simple_form', '~> 3.2', '<= 3.5.0'
# parser 2.5.0.0 broke local and Travis rubocop checks due to a change in parsing
spec.add_development_dependency 'parser', '< 2.5'
end

0 comments on commit c634b37

Please sign in to comment.