use Kernel#Array
to cast values to an Array
#197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
squash out error prone local logic for array casting, use
Kernel#Array
instead.
the older logic would fail to cast in the case that the value was a String,
requiring a tight integration between the forms input objects and the
application's forms/models. since the very next line is going to fail if we fail
to cast to an Array, let's do so aggressively here.
it looks as though this line once used
Array#wrap
for this, but this onlyworks if the object responds to
#to_ary
(Ruby's implicit cast); otherwiseit results in a value like
[["blah"]]
.Kernel#Array
is willing to perform anexplicit cast.