Release 5.0.0 #165
Merged
Release 5.0.0 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
providing the Contributor and Publisher models within the test suite for the presenters after updating to active-fedora release 12.1.0; Ensuring that Travis CI tests against Rails 5.1 and 5.0 releases; Ensuring that the tests are restructured for simple_form releases 3.5.0 onwards; Updating to version 5.0.0
6c845c3 to
97e60e8
Compare
dfd13e3 to
e50804b
Compare
e50804b to
85128c3
Compare
6b6f708 to
aee2c45
Compare
cjcolvar
commented
Mar 26, 2019
| @@ -1,3 +1,3 @@ | |||
| module HydraEditor | |||
| VERSION = '4.0.2'.freeze | |||
| VERSION = '5.0.0'.freeze | |||
There was a problem hiding this comment.
I don't understand why code climate isn't marking this as covered after I added the test for version. I think this is the only changed line that is included in the diff coverage (currently at 0%).
| s.add_dependency "rails", ">= 5.0.7", "< 6" | ||
| s.add_dependency "simple_form", '~> 4.0' | ||
| s.add_dependency "rails", ">= 5", "< 6" | ||
| s.add_dependency "simple_form", '~> 4.1.0' |
There was a problem hiding this comment.
I'm going to defer to @no-reply for this, as I'm still finding this to be a later release than the warning on https://github.com/samvera/hyrax/blob/master/hyrax.gemspec#L116
There was a problem hiding this comment.
This was discussed on Slack, and it was clarified that this should not block the proposed release.
jrgriffiniii
approved these changes
Mar 26, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #164 with additional changes:
coverallsbecause it requiresthor0.19.x which doesn't load correctly under the generated internal test app. Replaces this with codeclimate.engine_cartto 2.2simple_form~> 4.1 since version 3.5 failed the testsactive-fedorato let bundler resolve the proper versions