Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the HTML partials to be configurable #112

Merged
merged 3 commits into from
Apr 28, 2016
Merged

Allow the HTML partials to be configurable #112

merged 3 commits into from
Apr 28, 2016

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Apr 28, 2016

Also added jasmine testing.

@awead
Copy link
Contributor

awead commented Apr 28, 2016

👍

this.listClass = '.listing';
this.fieldWrapperClass = options.fieldWrapperClass;
this.warningClass = options.warningClass;
this.listClass = options.listClass;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's certainly a nicer way to handle this.

bitbucket is rate limiting downloads and sometimes this causes the build
to fail.
@grosscol grosscol merged commit 031b6c2 into master Apr 28, 2016
@jcoyne jcoyne deleted the jasmine branch April 28, 2016 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants