Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ams gbh valkyrie support #899

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
374e126
create an object factory that supports Valkyrie
bkiahstroud Jun 27, 2023
09de2cc
temp gem conflict workaround
bkiahstroud Jul 7, 2023
28875a8
:gear: upgrade dry-monads dependency to ~> 1.5.0
Aug 21, 2023
df96de6
:broom: Add extra parameter for fill_in_blank_source_identifiers
Aug 24, 2023
bae61a7
Revert ":broom: Add extra parameter for fill_in_blank_source_identifi…
Aug 24, 2023
fe51a43
:broom: delegate create_parent_child_relationships from importer to p…
Aug 25, 2023
3dac0f5
allow ruby 3 syntax in migrations
orangewolf Aug 29, 2023
a9a90ba
Merge remote-tracking branch 'origin/i672-valkyrie-support' into hyra…
Aug 29, 2023
86adf9a
:broom: change exists? to exist? to support Ruby 3.2
Aug 30, 2023
ba359f6
:construction: add support for Hyrax 5, valkyrie and ruby 3.2
Aug 30, 2023
e8677bb
add temp workaround for blank title and creator
Aug 31, 2023
f6fb201
:gear: Switch find methods with custom queries for Valkyrie
Sep 7, 2023
1def082
Merge branch 'main' into hyrax-4-valkyrie-support
orangewolf Sep 12, 2023
03544c7
hyrax 4 permission service does both valk and non-valk
orangewolf Sep 12, 2023
2bf6024
new bagit
orangewolf Sep 13, 2023
56101af
handle validation failure
orangewolf Sep 15, 2023
759a481
better failure detection for vaklyrie object
orangewolf Sep 15, 2023
9724643
fix validation message
orangewolf Sep 15, 2023
ed49dc2
importer failure helpers
orangewolf Sep 15, 2023
ba7a071
improve multiple detection in matchers
orangewolf Dec 12, 2023
784798d
fix matcher on missing field
orangewolf Dec 15, 2023
c2ee9bc
rob cant remember that its include?
orangewolf Dec 15, 2023
ba6933c
Merge branch 'main' into ams-gbh-valkyrie-support
jeremyf Jan 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
better failure detection for vaklyrie object
  • Loading branch information
orangewolf committed Sep 15, 2023
commit 759a481c60153d649f9a312b83bcd92fb49be19b
7 changes: 6 additions & 1 deletion app/factories/bulkrax/valkyrie_object_factory.rb
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,12 @@ def create
)
.call(cx)

raise StandardError, "#{result.failure[0]} - #{result.failure[1].full_messages.join(',')}", result.trace if result.failure?
if result.failure?
msg = result.failure[0]
msg += " - #{result.failure[1].full_messages.join(',')}" if result.failure[1].respond_to?(:full_messages)
raise StandardError, msg, result.trace
end

@object = result.value!

@object
Expand Down