Skip to content

Commit

Permalink
🐛 Fix parser field visibility on importer edit form (#1007)
Browse files Browse the repository at this point in the history
* 🐛 Fix parser field visibility on importer edit form

The form initialization check was previously only looking for new forms
(#new_importer), causing the JavaScript field visibility logic to be
skipped entirely on edit pages. This meant parser-specific fields weren't
being properly hidden/shown when editing existing importers.

Added .edit_importer to the form check to ensure the field visibility
logic runs on both new and edit forms.

* Pin concurrent-ruby to v1.3.4 to maintain logger dependency

- Addresses logger dependency removal in concurrent-ruby v1.3.5
- Ensures compatibility with Rails versions before 7.1

---------

Co-authored-by: Shana Moore <shana@scientist.com>
  • Loading branch information
ShanaLMoore and Shana Moore authored Jan 17, 2025
1 parent f76a6bd commit 359e331
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ gemspec
gem 'blacklight'
gem 'bootstrap-sass', '~> 3.4.1'
gem 'coderay'
gem 'concurrent-ruby', '1.3.4'
gem 'factory_bot_rails'

# Conditional logic based on Ruby version
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/bulkrax/importers.js.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// All this logic will automatically be available in application.js.

function prepBulkrax(event) {
if($('form#new_importer').length < 1) {
if($('form#new_importer, form.edit_importer').length < 1) {
return true;
}

Expand Down

0 comments on commit 359e331

Please sign in to comment.