Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI setup #423

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Fix CI setup #423

merged 3 commits into from
Jul 22, 2024

Conversation

jrochkind
Copy link
Contributor

@jrochkind jrochkind commented Jul 22, 2024

Several accumulated test setup things were preventing green CI. In some cases I don't really understand how CI used to pass but stopped with no code changes, but these changes all make sense.

Fix rubocop violation on parens around logical expression

Don't know exactly how this got in main branch, but currently failing build due to:

lib/browse_everything/driver/base.rb:72:19: C: [Correctable] Style/RedundantParentheses: Don't use parentheses around a logical expression.
        @name ||= (@config[:name] || self.class.name.split(/::/).last.titleize)

OpenStruct reference

Again can't explain why this passed CI at some previous point but stopped, but was getting errors with:

     NameError:
       uninitialized constant BrowseEverything::Auth::Google::OpenStruct
     # ./lib/browse_everything/auth/google/request_parameters.rb:7:in `<module:Google>'

Fixed with require 'ostruct' and changing reference to explicit top-level ::OpenStruct.

Sqlite3 version

sqlite3 ruby gem 2.x came out a few months ago. But Rails versions <= 7.1 still need to use 1.x I think? Error like:

       # Gem::LoadError:
       #   can't activate sqlite3 (~> 1.4), already activated sqlite3-2.0.2. Make sure all dependencies are added to Gemfile.

Changed development dependency in gemspec to:

spec.add_development_dependency 'sqlite3', "~> 1.4"

Don't know exactly how this got in main branch, but currently failing build due to:

```
lib/browse_everything/driver/base.rb:72:19: C: [Correctable] Style/RedundantParentheses: Don't use parentheses around a logical expression.
        @name ||= (@config[:name] || self.class.name.split(/::/).last.titleize)
```
@jrochkind jrochkind changed the title Fix rubocop violation on parens around logical expression Fix CI setup Jul 22, 2024
@jrochkind jrochkind marked this pull request as draft July 22, 2024 17:30
@jrochkind jrochkind force-pushed the fix_rubocop_parens branch from 0658091 to ff42f0b Compare July 22, 2024 17:31
@jrochkind jrochkind marked this pull request as ready for review July 22, 2024 17:41
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for fixing this!

@jrochkind jrochkind merged commit 3214d55 into main Jul 22, 2024
9 checks passed
@jrochkind jrochkind deleted the fix_rubocop_parens branch July 22, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants