Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI with Ruby 3.2 #416

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Run CI with Ruby 3.2 #416

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
963c3e0
Run CI with Ruby 3.2
jrochkind Jan 9, 2023
38e5968
test with latest rails 7.0.x, 7.0.4
jrochkind Jan 9, 2023
6140004
update CI bundler to latest
jrochkind Jan 9, 2023
aed9772
add ruby 3.2 to CI 'nightly' section as well
jrochkind Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ jobs:
workflows:
ci:
jobs:
- build:
name: "ruby3-2_rails7-0"
ruby_version: 3.2.0
rails_version: 7.0.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about bumping the rails version to the latest? It would at least kick off another build to see if the nokogiri issue gets resolved like in QA. 🤷

Suggested change
rails_version: 7.0.3
rails_version: 7.0.4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice, catch, sure, we should do that either way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that changes it... I wonder if that means it was an issue with how we do gem caching in our circleCI orb, like maybe changing rails version broke the cache...

but if the builds never get newly released versions of gems unless rails version changes, that's actually not great for CI on several grounds (you will not be testing against actual latest dependencies).

- build:
name: "ruby3-1_rails7-0"
ruby_version: 3.1.2
Expand Down