Actually get dummy test app running properly and passing feature tests #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deacf46 to
febaa8d
Compare
* Configure dummy test all with the test controller/views for demo under test
* properly set up sprockets for bootstrap 4 to include JS in dummy app
* properly get all dummy app dependencies set up -- this is the weirdest most confusing part
* dependencies are actually listed in .gemspec as development dependencies
* but may also need to be require'd in application.rb, which would normally happen automatically if they were
in a real Gemfile
* We give up on being able to test both bootstrap 3 and 4 -- that's not really tenable with the dummy app approach, since they use different gems entirely, and different local CSS files. We only test bootstrap 4 now.
* Actually enable the formerly disabled feature tests!
febaa8d to
d7db9f6
Compare
|
Ok getting very close! But we were trying to configure browse_everything_providers.yml, under test, with a But it can only take an absolute path? And we need to commit to repo... where the absolute path is going to be different depending on where the repo is checked out, etc. Hmm. We may expand it to take a relative path (to CWD)... if opted into? |
9ccef02 to
b86417d
Compare
This was referenced Jun 16, 2022
If set to true, then `home` can be a relative path (relative to Rails.root). The use case is mainly for CI/dummy test app setup. Added new param to make it opt-in, to make sure it's completely backwards compat and does not introduce any potential security issues -- you need to opt in to new supported behavior with new allow_relative_home param.
b86417d to
c03a18a
Compare
…d since we've switched to dummy_test_app that has versions of these files committed
|
OK building on top of #406 this is now ready to review -- feature tests re-enabled and passing, on our new checked-in dummy app! |
| @@ -2,6 +2,7 @@ | |||
| version: 2.1 | |||
| orbs: | |||
| samvera: samvera/circleci-orb@1.0 | |||
| browser-tools: circleci/browser-tools@1.1 | |||
| @@ -19,6 +20,8 @@ jobs: | |||
| environment: | |||
| RAILS_VERSION: << parameters.rails_version >> | |||
| steps: | |||
| - browser-tools/install-chrome | |||
| @@ -3,7 +3,8 @@ | |||
| # The file_system provider can be a path to any directory on the server where your application is running. | |||
| # | |||
| file_system: | |||
| home: /Users/jrochkind/code/browse-everything/.internal_test_app | |||
There was a problem hiding this comment.
I am sorry for missing this line within a previous pull request review.
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| shared_examples 'browseable files' do | |||
| # This is a work-around until the support for Webpacker is resolved | |||
| xit 'selects files from the filesystem' do | |||
| it 'selects files from the filesystem' do | |||
| @@ -1,7 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| describe 'Compiling the stylesheets', type: :feature, js: true do | |||
| xit 'does not raise errors' do | |||
| it 'does not raise errors' do | |||
jrgriffiniii
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure dummy test all with the test controller/views for demo under test
properly set up sprockets for bootstrap 4 to include JS in dummy app
properly get all dummy app dependencies set up -- this is the weirdest most confusing part
in a real Gemfile
We give up on being able to test both bootstrap 3 and 4 -- that's not really tenable with the dummy app approach, since they use different gems entirely, and different local CSS files. We only test bootstrap 4 now.
Actually enable the formerly disabled feature tests!
Includes in this PR one commit:
FileSystem driver has new
allow_relative_homeparamIf set to true, then
homecan be a relative path (relative to Rails.root).The use case is mainly for CI/dummy test app setup. Added new param to make it opt-in, to make sure it's completely backwards compat and does not introduce any potential security issues -- you need to opt in to new supported behavior with new allow_relative_home param.