Skip to content

Commit

Permalink
Remove karma/jasmine JS tests, and all infrastructure
Browse files Browse the repository at this point in the history
These are not working and have not been working for some time -- unclear how long. There was only one very simple/unclear-value test in there anyway.

Remove the whole karma/jasmine infrastructure, as it wasn't working, we don't currently have the capaccity to get it working, and it's one more moving part to go wrong.
  • Loading branch information
jrochkind committed Jun 14, 2022
1 parent 128a4e2 commit cf8de5d
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 11,952 deletions.
4 changes: 0 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ jobs:

- samvera/rubocop

- run:
name: Install Karma for JavaScript and functional tests
command: sudo npm install -g karma karma-jasmine karma-chrome-launcher

- samvera/parallel_rspec

workflows:
Expand Down
5 changes: 0 additions & 5 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ Metrics/MethodLength:
Metrics/ParameterLists:
Max: 7

# Offense count: 1
RSpec/DescribeClass:
Exclude:
- 'spec/javascripts/jasmine_spec.rb'

# Offense count: 2
RSpec/MultipleExpectations:
Max: 2
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ However, we also recommend merging the contents of this file into your main `app
## Testing
This is a Rails Engine which is tested using the [engine_cart](https://github.com/cbeer/engine_cart) Gem and rspec.

One rspec test invokes [karma](https://karma-runner.github.io/latest/index.html) to run Javascript tests. For this test to succeed, you need to install karma on your system, first by making sure `npm` is installed, and then run `npm install -g karma karma-jasmine karma-chrome-launcher`.

Test suites may be executed with the following invocation:

```bash
Expand Down
1 change: 0 additions & 1 deletion browse-everything.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'coveralls'
spec.add_development_dependency 'engine_cart', '~> 2.2'
spec.add_development_dependency 'factory_bot_rails'
spec.add_development_dependency 'jasmine', '~> 2.3'
spec.add_development_dependency 'pry-byebug'
spec.add_development_dependency 'rails-controller-testing'
spec.add_development_dependency 'rake'
Expand Down
71 changes: 0 additions & 71 deletions karma.conf.js

This file was deleted.

7 changes: 0 additions & 7 deletions spec/javascripts/behavior_spec.js

This file was deleted.

Loading

0 comments on commit cf8de5d

Please sign in to comment.