-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom icons 596 #619
Zoom icons 596 #619
Conversation
@Dananji Looking at the screenshot, it looks like it's showing the progress bar above the other player controls to create space for the progress bar. I think this looks ok just from the screenshot (although I do notice that the icons on the second row are not vertically aligned). We'll have to test this out once committed to see how we feel about the min-width. |
@joncameron You ok with moving the progress bar to a separate line once screen width starts to decrease. |
Yep, I'm good with this. @Dananji please go ahead and update the PR from draft so we can merge it in and play around with the change. |
I did not test this out in mobile devices as part of the work I did. So, I will test in mobile devices to make sure everything works as expected and make any changes as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! I just had one question.
src/components/MediaPlayer/VideoJS/components/js/VideoJSNextButton.js
Outdated
Show resolved
Hide resolved
cee8b82
to
f6eac79
Compare
@joncameron Dananji changed the volume control so that it would not expand upward over top of the progress bar in these situations. Is that ok with you for first pass and we can try it out once this gets to QA? @Dananji Did you consider using the horizontal volume slider like we use for audio only items? |
Yes, I did. And it looked a bit odd with the empty space on top and bottom for me. I think this wasn't noticeable before with the audio player because the control bar height was smaller then. In this work I increased the control bar height a little bit to make space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Related issue: #596
Included in this PR:
min-width
so that, all player controls are displayed without overflowing when the UI is zoomed-in