Improve VTT parsing #518
Merged
Improve VTT parsing #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaball
reviewed
Jun 12, 2024
| t.times = isNote ? "" : line; | ||
| t.tag = isNote ? TRANSCRIPT_CUE_TYPES.note : TRANSCRIPT_CUE_TYPES.timedCue; | ||
| t.line = isNote ? line : ''; | ||
| // Make sure there is a single space separating NOTE from the comment for single or multi-line comments | ||
| t.line = isNote ? line.replace(/^NOTE\s*/,'NOTE ') : ''; | ||
| i++; |
There was a problem hiding this comment.
Does this still need to be in the loop with adding i++ to the for loop declaration?
There was a problem hiding this comment.
Yes, it advances to the next line so the while loop test starts with the line after the start of the cue/note.
masaball
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #499 and improves handling of NOTE comments. Also includes spaces that were missing between lines of a cue or comment.
I removed
cleanTimedTextbecause I needed the new lines to flow through togroupTimedTextLineswhere I added additional handling of NOTE comments.