Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto advance and player crashing on Canvas change #432

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix auto advance and player crashing on Canvas change #432

merged 1 commit into from
Feb 29, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Feb 23, 2024

Fixes in the PR:

  • Auto advance not working when the first Canvas in the Manifest is empty
  • Video.js instance crashing when switching between canvases due to the player.paused() check referring to a null instance for a fraction of a second

cjcolvar
cjcolvar reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/components/MediaPlayer/VideoJS/components/js/VideoJSProgress.js Show resolved Hide resolved
@Dananji Dananji merged commit e9c1ac5 into main Feb 29, 2024
2 checks passed
@Dananji Dananji deleted the fix-autoadvance branch February 29, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar