Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse playlist homepage as positional urls into structure links #424

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Feb 20, 2024

Wait for the relevant changes to the Manifest generation in Avalon, make any changes to parsing as needed before merging.

Tested a playlist manifest in Avalon with the changes locally, and these code changes works with the playlist manifests!

This PR moves the parsing of the summary property at Canvas level from getStructureRanges() to canvasesInManifest() function, where Canvas related information is parsed.

Related issue: #366

@Dananji Dananji marked this pull request as ready for review February 21, 2024 18:15
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a typo in one of the test.

src/services/iiif-parser.test.js Outdated Show resolved Hide resolved
Co-authored-by: Mason Ballengee <68433277+masaball@users.noreply.github.com>
@Dananji Dananji merged commit 267a0ec into main Feb 22, 2024
2 checks passed
@Dananji Dananji deleted the playlist-homepage branch February 22, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants