Increase Default Timeout #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
reviewed
Dec 13, 2023
There was a problem hiding this comment.
It looks like there are some tests that are expecting the timeout to be 3000 and need to get updated:
src/services/utility-helpers.test.js:437
src/services/utility-helpers.test.js:442
src/services/iiif-parser.test.js:257
src/services/iiif-parser.test.js:263
src/services/iiif-parser.test.js:270
Update the timeout value for #316
11567a2 to
1ef4456
Compare
|
I fixed the failing tests and rebased this branch on the latest from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the timeout value for #316