Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas metadata #311

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Canvas metadata #311

merged 6 commits into from
Dec 15, 2023

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Dec 6, 2023

With default props => displayOnlyCanvasMetadata=false, displayAllMetadata=false:
image

With displayOnlyCanvasMetadata=true:
image

With displayAllMetadata=true:
image

Canvas details change with autoplay:

Canvas.Details.Update.with.Playback.webm

Usage of new props;

Prop values Display in UI
default props only Manifest metadata
displayOnlyCanvasMetadata=true with other default props only Canvas metadata
displayOnlyCanvasMetadata=true && displayTitle=false with other default props only Canvas metadata
displayOnlyCanvasMetadata=true with other default props only Canvas metadata w/o title
displayOnlyCanvasMetadata=true && displayAllMetadata=true with other default props both Canvas and Manifest metadata
displayAllMetadata=true with other default props both Canvas and Manifest metadata
displayAllMetadata=true && displayTitle=false with other default props both Canvas and Manifest metadata w/o displaying title in both Manifest and Canvas metadata

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I had a few questions/comments but nothing major.

src/components/MetadataDisplay/MetadataDisplay.js Outdated Show resolved Hide resolved
src/components/MetadataDisplay/MetadataDisplay.js Outdated Show resolved Hide resolved
src/services/iiif-parser.test.js Outdated Show resolved Hide resolved
@Dananji Dananji requested a review from cjcolvar December 14, 2023 19:44
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Dananji Dananji merged commit 501af72 into main Dec 15, 2023
@Dananji Dananji deleted the canvas-metadata branch December 15, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants