Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add active section #275

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Add active section #275

merged 4 commits into from
Nov 1, 2023

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Oct 30, 2023

Mark active section when there are;

Canvas with child timespans:
image

Canvas without child timespans:
image

Canvas without children (timespans/divs):
image

cjcolvar
cjcolvar reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as far as I can tell. I noticed that there are a number of blocks that have been commented out. Can those be removed?

@Dananji Dananji requested a review from cjcolvar October 31, 2023 17:37
cjcolvar
cjcolvar approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning that up!

@Dananji Dananji merged commit 9699f03 into main Nov 1, 2023
@Dananji Dananji deleted the add-active-section branch November 1, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar