Replace videojs-hotkeys with builtin hotkeys function #250
Conversation
Co-authored-by: Dananji Withana <dwithana@iu.edu>
|
This looks great 💯 |
| this.currentTime(this.currentTime() + 5); | ||
| } | ||
|
|
||
| // Left arrow seeks 5 seconds back | ||
| if (event.which === 37) { | ||
| this.currentTime(this.currentTime() - 5); |
There was a problem hiding this comment.
Do we need a check here for the duration of the media in case the currentTime after the 5 second adjustment is either greater than the duration or less than 0 or the alternate start time of the media?
Or is it getting handled on the VideoJS end of things?
There was a problem hiding this comment.
It looks like it is getting handled on the VideoJS end of things. Trying to seek back past the start time of a video/segment gets set to the start time. Seeking past the end of a video/segment either triggers the autoplay of the next section or, if there are no more sections, triggers the "Transcripts undefined" error we've recently been seeing which is unrelated to this specific seeking behavior.
Neither case seems to triggers any other error messages or weird behavior.
Videojs-hotkeys was not interfacing correctly between Avalon and embedded Ramp. This could be an issue encountered by other implementers. Rather than cobble together a fix on the Avalon side and documenting that for others, it felt better to try to change the approach in Ramp so that hopefully workarounds would not be necessary.
To that end, recent versions of VideoJS have added a builtin hotkey ability so we are going to try switching to that. This currently requires building the hotkeys out from scratch because the defaults do not include all of the functionality we require and adding any customization disables the defaults. It may be worthwhile exploring contributing "seek" and "volume" hotkey components back upstream to be added to the VideoJS default behaviors but that is a future discussion.