Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add i18n support with language optin in VideoJS #235

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Add i18n support with language optin in VideoJS #235

merged 2 commits into from
Sep 25, 2023

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Sep 11, 2023

English:

image

French:

image

Part of #184

@Dananji Dananji requested a review from cjcolvar September 14, 2023 14:51
cjcolvar
cjcolvar approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I wonder if we'll want to cache any of this importing (or if it already magically happens) so it doesn't have to load with each video.js instantiation. We can wait and see if this actually is a performance issue though.

@Dananji Dananji merged commit c542b64 into main Sep 25, 2023
@Dananji Dananji deleted the videojs-i18n branch September 25, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar