Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata component #192

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Metadata component #192

merged 5 commits into from
Jun 13, 2023

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented May 30, 2023

Metadata component displays the metadata from a manifest if available. There are 2 props;

  • displayTitle: defaults to true to display title within the metadata display
  • showHeading: defaults to true to display header element in the display

In Netlify demo site with Transcripts and Details in a tabbed panel;
Screenshot from 2023-05-31 14-18-59

When metadata is not available in the manifest:
Screenshot from 2023-05-31 14-17-41

As a raw component in the library (from Styleguidist docs):
Screenshot from 2023-05-30 16-36-42

Closes #172

@Dananji Dananji force-pushed the metadata-component branch from c66b820 to b2bf945 Compare May 31, 2023 16:30
@Dananji Dananji marked this pull request as ready for review May 31, 2023 18:19
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. The only question/concern I have is around HTML markup in metadata values.

src/services/iiif-parser.js Show resolved Hide resolved
@Dananji Dananji force-pushed the metadata-component branch from 8957c86 to 459d58c Compare June 12, 2023 14:06
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Dananji Dananji merged commit 3f0789f into main Jun 13, 2023
@Dananji Dananji deleted the metadata-component branch June 13, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create metadata component for Ramp
2 participants