Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test progress bar #128

Merged
merged 20 commits into from
Apr 20, 2022
Merged

Test progress bar #128

merged 20 commits into from
Apr 20, 2022

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Mar 8, 2022

No description provided.

Dananji and others added 18 commits February 15, 2022 14:47
@Dananji
Adding a custom progress bar component
57f262e
@Dananji
Use options with custom component
6d11b09
@Dananji
[WIP] Add time-tooltip to progress bar
1592271
@Dananji
Fixed mouse event for timetooltip
67c8739
@Dananji
[WIP] Render multiple resources in a single canvas
9f8f7ea
@Dananji
Changes to parser to accommodate multiple items in single canvas
9d39c76
@Dananji
Parse 'start' prop in manifests, render accordingly in all components (…
546b2a9 
…#107)

* Parse 'start' prop in manifests, render accordingly in all components

* New styleguidist docs

* Changes from review feedback
@Dananji
Fix rebase errors
dd782c5
@Dananji
[WIP] Multi-item canvas with custom progress bar
9207c77
@Dananji
Work in progress: align times
a188ed8
@Dananji
Fixed time update
32a23e5
@Dananji
Structure navigation fix with tests
d1b3871
@Dananji
Add navigation for multiple items via player
6d7c231
@Dananji
Fix timetooltip styling
b878e47
@Dananji
Fix time update for seek events
b0da2b3
@Dananji
Fix timetooltip glitch with videojs events
ce51bee
@Dananji
Handle videojs ended event and time updates
75d7b3a
@Dananji
Code cleanup and add comments
7ffae6c
@cla-bot cla-bot bot added the cla-signed label Mar 8, 2022
cjcolvar
cjcolvar reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a major PR! I left a few questions and suggestions but overall this looks to be in good shape!

yarn-error.log Outdated Show resolved Hide resolved
src/components/MediaPlayer/VideoJSComponents/VideoJSProgress.scss Show resolved Hide resolved
src/components/MediaPlayer/VideoJSComponents/VideoJSProgress.js Outdated Show resolved Hide resolved
src/components/Transcript/Transcript.js Outdated Show resolved Hide resolved
src/services/utility-helpers.js Outdated Show resolved Hide resolved
src/services/utility-helpers.js Show resolved Hide resolved
src/services/transcript-parser.js Show resolved Hide resolved
src/services/iiif-parser.js Show resolved Hide resolved
Dananji and others added 2 commits April 20, 2022 10:38
@Dananji @cjcolvar
Update src/services/utility-helpers.js
f0cf38b 
Refine if-else statement

Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
@Dananji
Fixes from feedback
0a25419
@Dananji Dananji force-pushed the test-progress-bar branch from 1285508 to 0a25419 Compare April 20, 2022 17:01
@Dananji Dananji merged commit d211e96 into main Apr 20, 2022
@Dananji Dananji deleted the test-progress-bar branch April 20, 2022 17:08
@cjcolvar cjcolvar mentioned this pull request May 4, 2022
Merged
@Dananji Dananji mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar