Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback to get missing fonts #188

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

erzu12
Copy link

@erzu12 erzu12 commented Oct 24, 2024

This allows a user to register a callback to be called when a font is missing, as suggested in #178.

For now, I have made the API more C++ style than the other add_font functions, but feedback on this is very welcome.

@sammycage
Copy link
Owner

Hello @erzu12

Thank you so much for the great idea and for putting time into this! This callback functionality for handling missing fonts is a creative approach, and I can see its potential value.

That said, the current implementation feels a bit complex. It seems to duplicate some of the existing functionality of add_font, which might add unnecessary redundancy. While I appreciate the more C++-style approach here, it introduces an additional layer that could complicate usage for developers accustomed to our existing API.

At this stage, keeping the API streamlined and straightforward is a key priority. Could we consider a simpler way to extend add_font for this purpose instead? Perhaps we could explore a lighter modification that integrates more naturally with the current structure.

Thanks again for your contribution, and looking forward to more of your ideas!

@sammycage sammycage marked this pull request as draft November 3, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants