Menu on Main #161
Merged
Menu on Main #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdatkins
approved these changes
Feb 13, 2024
frontend/src/App.tsx
Outdated
| path="/live/" | ||
| element={<WelcomePage asyncUser={asyncUser} songbooks={songbooks} />} | ||
| > | ||
| <Route path="/live/" element={<WishlistForm />} /> |
There was a problem hiding this comment.
I think this makes the path for wishlist /live/live... though maybe not since you're using an absolute path. For readability I would remove the path and instead just use index (no value needed, it'll default to true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls welcome page user tasks into separate components (join sing-along, view/add wish list, view/create songbook, view/create sing-along)