ILlmFunction.ISeparated.llm to be not null.
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though no property exists in the LLM side (properties exist only in the Human side), the `ILlmFunction.ISeparated.llm` property value should be not null for covenience. This PR enforces the `ILlmFunction.ISeparated.llm` not to be `null`.
samchon
added a commit
to samchon/typia
that referenced
this pull request
Jan 13, 2025
As OpenAI (ChatGPT) restricts function name and description lengths (64 and 1,024), `@samchon/openapi`'s `HttpLlm.application()` function converting OpenAPI document to LLM function calling application has adopted it. Therefore, this PR makes `typia` to occur compilation error when 64 length over function name comes, or 1,024 length over descripted function comes. Also, `typia` has allowed empty parameterized functions in the `typia.llm.application()` function.
samchon
added a commit
to samchon/typia
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though no property exists in the LLM side (properties exist only in the Human side), the
ILlmFunction.ISeparated.llmproperty value should be not null for covenience.This PR enforces the
ILlmFunction.ISeparated.llmnot to benull.This pull request includes several changes aimed at ensuring the
llmproperty always has a defined structure, even when it would otherwise be null. The changes span multiple files and affect both the schema composers and the test files.Schema Composer Changes:
src/composers/llm/ChatGptSchemaComposer.ts: Updated thellmproperty to default to an empty object structure if it is null.src/composers/llm/ClaudeSchemaComposer.ts: Modified theseparateParametersfunction to ensure thellmproperty has a defined structure.src/composers/llm/GeminiSchemaComposer.ts: Adjusted theseparateParametersfunction to return a structuredllmproperty.src/composers/llm/LlmSchemaV3Composer.ts: Ensured thellmproperty defaults to an empty object structure if it is null.src/composers/llm/LlmSchemaV3_1Composer.ts: Updated thellmproperty to have a default structure when null.Structure Changes:
src/structures/IHttpLlmFunction.ts: Modified theISeparatedinterface to ensure thellmproperty is never null.src/structures/ILlmFunction.ts: Updated theISeparatedinterface to ensure thellmproperty always has a defined structure.Test File Changes:
test/features/llm/validate_llm_parameters_separate_array.ts: Updated tests to reflect the new default structure of thellmproperty.test/features/llm/validate_llm_parameters_separate_nested.ts: Adjusted tests to ensure thellmproperty has a defined structure.test/features/llm/validate_llm_parameters_separate_object.ts: Modified tests to account for the new default structure of thellmproperty.test/features/llm/validate_llm_parameters_separate_ref.ts: Updated tests to reflect the changes in thellmproperty structure.test/features/llm/validate_llm_schema_separate_string.ts: Adjusted tests to ensure thellmproperty always has a defined structure.