-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript definition files #3
Conversation
@aalpgiray why Overwrite<Store, any> ? |
I was using a library called easy-peasy based on redux but Store type is an extention of redux Store. Does it broke anything? |
i think easy-peasy createStore should extend redux Store type, and redux-first-history just use store:Store? no? |
Perhaps you are right. I am on it. |
ok,
then i will merge this pr. |
Ok, I removed |
@aalpgiray merged! |
Thanks |
I am kinda new at this. If you have any rules or guide for contributors, please share.