Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript definition files #3

Merged
merged 8 commits into from
Dec 16, 2018
Merged

Conversation

aalpgiray
Copy link
Contributor

I am kinda new at this. If you have any rules or guide for contributors, please share.

@salvoravida
Copy link
Owner

@aalpgiray why Overwrite<Store, any> ?

@aalpgiray
Copy link
Contributor Author

I was using a library called easy-peasy based on redux but Store type is an extention of redux Store. Does it broke anything?

@salvoravida
Copy link
Owner

i think easy-peasy createStore should extend redux Store type, and redux-first-history just use store:Store?

no?

@aalpgiray
Copy link
Contributor Author

Perhaps you are right. I am on it.

@salvoravida
Copy link
Owner

ok,

  1. fix : declare function createReduxHistory(store: Store): History;
  2. remove type-zoo/types dep.

then i will merge this pr.

@aalpgiray
Copy link
Contributor Author

Ok, I removed type-zoo and replaced Overwrite<Store, any> with Store .

@salvoravida salvoravida merged commit 2b23908 into salvoravida:master Dec 16, 2018
@salvoravida
Copy link
Owner

@aalpgiray merged!

@aalpgiray
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants