Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AllowInboundRules when configuring Windows Firewall #67713

Open
wants to merge 2 commits into
base: 3006.x
Choose a base branch
from

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented Feb 7, 2025

What does this PR do?

Fixes an issue with the win_lgpo_netsh.py salt util. It was stacktracing when the AllowInboundRules setting was set to True.

What issues does this PR fix or reference?

Fixes # 67122

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs the linter fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] win_lgpo may raise KeyError exception from _get_inbound_text with 3006.9
2 participants