[3006.x] Fix 65777 : Default to utf-8 on all systems #65791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee9ae0 to
081c88c
Compare
Adds a new encoding parameter to the ini module to handle scenarios where the ini file encoding is not utf-8.
Test reading and writing to utf-8, utf-16, utf-16-le and utf-32-le ini files
Add missing documentation for all functions Add documentation for new parameter `encoding` Add Returns section to documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This attempts to fix some Unicode errors on Windows. Specifically when reading an INI file that contains Unicode characters. Though this should make Salt use utf-8 encoding by default. This attempts to be a more universal fix than just fixing a single module. We may need to address other modules that attempted to address Unicode issues with Python2 and others using MBCS on Windows.
What issues does this PR fix or reference?
Fixes: #65777
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes