[3006.x] Fix deleting from utils/aws.py::__AssumeCache__ while iterating over it
#64392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utils/aws.py::__AssumeCache__ while iterating over itutils/aws.py::__AssumeCache__ while iterating over it
utils/aws.py::__AssumeCache__ while iterating over itutils/aws.py::__AssumeCache__ while iterating over it
Ch3LL
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes use of invalid delete method for a dictionary and avoids deleting on the dictionary we iterate over.
What issues does this PR fix or reference?
Fixes: #61049
Previous Behavior
Invalid
.delete()method for a dictionary, and attempting to delete from the dictionary we are iterating over.New Behavior
Use of
delto delete from a dictionary, and don't delete from the dictionary we are iterating over, but a copy of it.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes