Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Fix setup.py called with salt args #64115

Merged
merged 1 commit into from
Apr 20, 2023
Merged

[3006.x] Fix setup.py called with salt args #64115

merged 1 commit into from
Apr 20, 2023

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Apr 19, 2023

What does this PR do?

Fixes running setup.py with --salt-cache-dir and --salt-config-dir.

What issues does this PR fix or reference?

Fixes: #64114

Previous Behavior

(heist-3.8)  ch3ll@megan-precision5550  ~/git/salt  ➦ 179532f902 <B>  GENERATE_SALT_SYSPATHS=True python setup.py --salt-config-dir=/etc/salt --salt-cache-dir=/var/cache/salt develop             
usage: setup.py [-h] [--next-release] ...
setup.py: error: unrecognized arguments: --salt-config-dir=/etc/salt --salt-cache-dir=/var/cache/salt

New Behavior

Builds and no error

@Ch3LL Ch3LL requested a review from a team as a code owner April 19, 2023 19:53
@Ch3LL Ch3LL requested review from MKLeb and removed request for a team April 19, 2023 19:53
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix setup.py called with salt args [3006.x] Fix setup.py called with salt args Apr 19, 2023
@Ch3LL Ch3LL temporarily deployed to ci April 19, 2023 23:59 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 19, 2023 23:59 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 19, 2023 23:59 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 20, 2023 01:03 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 20, 2023 01:03 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 20, 2023 01:03 — with GitHub Actions Inactive
@Ch3LL Ch3LL merged commit b35db04 into saltstack:3006.x Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@garethgreenaway garethgreenaway garethgreenaway approved these changes

@MKLeb MKLeb Awaiting requested review from MKLeb MKLeb was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ch3LL @s0undt3ch @garethgreenaway